Skip to content

koordlet: reduce the frequency of updating NodeResourceTopology#1221

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
wangxiaoq:sort-slice
Apr 17, 2023
Merged

koordlet: reduce the frequency of updating NodeResourceTopology#1221
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
wangxiaoq:sort-slice

Conversation

@wangxiaoq
Copy link
Contributor

…notations

Ⅰ. Describe what this PR does

Fix #1219

Ⅱ. Does this pull request fix one issue?

#1219

Ⅲ. Describe how to verify it

Just see the koordlet's log, expect that "topology is changed, need sync" is obviously reduced.

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…notations

Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (a68cefe) 65.73% compared to head (4fcf05b) 65.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
- Coverage   65.73%   65.70%   -0.03%     
==========================================
  Files         290      290              
  Lines       30652    30658       +6     
==========================================
- Hits        20148    20145       -3     
- Misses       9025     9034       +9     
  Partials     1479     1479              
Flag Coverage Δ
unittests 65.70% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dlet/statesinformer/states_noderesourcetopology.go 65.90% <50.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koordlet: make elements order consistent in NodeResourceTopology's an… koordlet: reduce the frequency of updating NodeResourceTopology Apr 14, 2023
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8d6e12a into koordinator-sh:main Apr 17, 2023
@saintube
Copy link
Member

/area koordlet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The update frequency of NodeResourceTopology CR is still high

4 participants